Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the check for different filesystem libs and fallback to Boost #662

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Remove the check for different filesystem libs and fallback to Boost #662

merged 1 commit into from
Sep 6, 2024

Conversation

tmadlener
Copy link
Collaborator

@tmadlener tmadlener commented Sep 5, 2024 •
edited
Loading

BEGINRELEASENOTES

  • Remove the cmake checks to figure out against which filesystem library to link, since all major compilers have had it properly integrated into their STLs for quite some time now. Also remove the fallback to Boost.

ENDRELEASENOTES

We haven't built against gcc <= 9.1 or LLVM <= 9 for quite some time, so I don't see a reason to keep these checks around.

andresailer
andresailer reviewed Sep 6, 2024
View reviewed changes
cmake/podioMacros.cmake
SET(${FS_LIBS} Boost::filesystem Boost::system PARENT_SCOPE)
SET_TARGET_PROPERTIES(Boost::filesystem
PROPERTIES
INTERFACE_COMPILE_DEFINITIONS USE_BOOST_FILESYSTEM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means we can also drop

podio/src/SIOBlock.cc

Line 8 in 98a786a

#ifdef USE_BOOST_FILESYSTEM

and

podio/src/SIOBlock.cc

Line 136 in 98a786a

#ifdef USE_BOOST_FILESYSTEM

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #664

@m-fila
Copy link
Contributor

m-fila commented Sep 6, 2024

std::filesystem is already used directly in the tests so the workaround wasn't even covering all the cases

@hegner hegner merged commit 8a117ee into AIDASoft:master Sep 6, 2024
17 of 18 checks passed
@tmadlener tmadlener deleted the rm-filesystem-checks branch September 6, 2024 10:50
@tmadlener tmadlener mentioned this pull request Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmadlener @m-fila @andresailer @hegner