Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Commit

Permalink
#332: Fix "Shift + Alt" key capture issue
Browse files Browse the repository at this point in the history
When "Shift + Alt + <any key>" was used, the OntoWiki JavaScript prevented the default behaviour, even when there was no matching shortcut.
This caused issues with e.g. french keyboards, where the "[" key depends on "Shift + Alt".
This change will fix this behaviour by only preventing the default, when the action is overwritten by OntoWiki.
  • Loading branch information
pfrischmuth committed Jun 1, 2016
1 parent b35e2cb commit c7dc7f7
Showing 1 changed file with 30 additions and 12 deletions.
42 changes: 30 additions & 12 deletions extensions/themes/silverblue/scripts/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,24 +34,42 @@ $(document).ready(function() {
$(document).keydown(function(e) {
if (/view\/?|resource\/properties\/?/gi.test(window.document.baseURI)) {
if (e.shiftKey && e.altKey) {
e.preventDefault();
var shouldPreventDefault = false;

switch(e.which) {
//e - 101 - edit E - 69
case 69 : $('.edit-enable').trigger('click'); break;
case 69 :
$('.edit-enable').trigger('click');
shouldPreventDefault = true;
break;
//a - 97 - add property - A - 65
case 65 : $('.property-add').trigger('click'); break;
case 65 :
$('.property-add').trigger('click');
e.preventDefault();
break;
//s - 115 - save S - 83
case 83 : if ($('.edit-enable').hasClass('active')) {
$('.edit.save').trigger('click');
};
break;
case 83 :
if ($('.edit-enable').hasClass('active')) {
$('.edit.save').trigger('click');
e.preventDefault();
};
break;
//c - 99 - cancel C - 67
case 67 : if ($('.edit-enable').hasClass('active')) {
$('.edit.cancel').trigger('click');
};
break;
case 67 :
if ($('.edit-enable').hasClass('active')) {
$('.edit.cancel').trigger('click');
e.preventDefault();
};
break;
//l - 108 - clone L - 76
case 76 : $('.clone-resource').trigger('click'); break;
case 76 :
$('.clone-resource').trigger('click');
e.preventDefault();
break;
}

if (shouldPreventDefault) {
e.preventDefault();
}
}
}
Expand Down

0 comments on commit c7dc7f7

Please sign in to comment.