Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

add HTTP_X_FORWARDED_PROTO #313

Closed
wants to merge 2 commits into from
Closed

add HTTP_X_FORWARDED_PROTO #313

wants to merge 2 commits into from

Conversation

hknochi
Copy link
Member

@hknochi hknochi commented Nov 17, 2014

add possibility to get configured https via header-param

description:
https://github.com/AKSW/OntoWiki/wiki/OntoWiki-behind-a-reverseProxy-(with-SSL)

@white-gecko
Copy link
Member

This line exceeds 120 characters and is not readable [1]. Please enable the codings standards in our development environment (make cs-install).
Furthermore your change overwrites any $_SERVER['HTTPS'] setting.
Please reorganize the code to an if-statement which correctly includes the preceding line.

[1] https://github.com/AKSW/OntoWiki/wiki/Coding-Standards

@hknochi
Copy link
Member Author

hknochi commented Nov 18, 2014

the added line override the preceding line only if $protocol isn't set to https up to this point. After a chack for "http" (no previous settings) this additionally method is checked.

@white-gecko
Copy link
Member

Furthermore there is also X-Forwarded-Protocol which seams to be in use for setting the original protocols in proxies.

Could you please also avoid The “?-:” notation?

[1] http://www.micahcarrick.com/using-ssl-behind-reverse-proxy-in-django.html

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants