Support Python 3.13 #284
Merged
Support Python 3.13 #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Weber <scy@scy.name>
scy
added
type:enhancement
`uv sync` should work on 3.13 now; tests however are a different beast. Signed-off-by: Tim Weber <scy@scy.name>
For pytest, any version ≥ 8 will break on `test_access_config_without_loading` (because the expected exception is _not_ being raised). This might be because something about the test setup or fixture handling changed; however, I could not find anything that looks related in the 8.0 changelog <https://docs.pytest.org/en/latest/changelog.html#pytest-8-0-0rc1-2023-12-30>. Will need to look into this in more detail. For SQLModel, we got lots of type checking and runtime errors on 0.0.11 or higher. I believe this is related to the additional checks they've introduced there <https://sqlmodel.tiangolo.com/release-notes/?h=sa_column#0011>. The bad thing is that it reads like these checks actually protect you from combining incompatible stuff in your models, which were silently ignored before, but didn't have the effect intended by the model creator. In other words: Our models might not be doing what we think they are, and we should look into this. Signed-off-by: Tim Weber <scy@scy.name>
Unfortunately, Pydantic < 2 seems to throw warnings when running the tests. There is no more recent 1.10 version available than the one we have, so I guess we'll fix this by upgrading to Pydantic 2, but for that, we'll need FastAPI ≥ 0.100. That doesn't seem so far from our current 0.95.1, but we're currently limited to SQLModel < 0.0.11 (see 706462b), and SQLModel doesn't support Pydantic 2 before 0.0.12. So, fixing the warnings will have to wait until the SQLModel update. Signed-off-by: Tim Weber <scy@scy.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.