Update FastAPI, python-multipart, and mypy #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally wanted to update just python-multipart, but then it complained about FastAPI's old way of importing it; thus I've decided to update FastAPI as well. And mypy also made sense, to reduce some of the false positives. FastAPI is now using `examples=[…]` instead of `example=…`. Got rid of some `type: ignore` markers by debugging the root cause. Updated the log filter to return bools instead of 0 and 1. The new `type: ignore` markers in `progress.py` are unfortunate, but that code is complicated and I don't have the time to thoroughly fix it, and especially make sure that I didn't break anything, right now. Signed-off-by: Tim Weber <scy@scy.name>
scy
added
type:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #269.
Originally wanted to update just python-multipart, but then it complained about FastAPI's old way of importing it; thus I've decided to update FastAPI as well. And mypy also made sense, to reduce some of the false positives.
FastAPI is now using
examples=[…]instead ofexample=….Got rid of some
type: ignoremarkers by debugging the root cause.Updated the log filter to return bools instead of 0 and 1.
The new
type: ignoremarkers inprogress.pyare unfortunate, but that code is complicated and I don't have the time to thoroughly fix it, and especially make sure that I didn't break anything, right now.