Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDBC User's Manual - JDBC 4.2 API References #475

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions Manuals/Altibase_7.3/eng/JDBC User's Manual.md
Original file line number Diff line number Diff line change
Expand Up @@ -969,6 +969,14 @@ Chapter 3.</p>
| Setting Range | N/A |
| Description | Specifies whether to include stored procedures in the result DatabaseMetaData.getProcedures() and DatabaseMetaData.getProcedureColumns() methods return. When this value is set to true, it includes stored procedures. When this value is set to false, stored procedures are not included. Hence, DatabaseMetaData.getFunctions() and DatabaseMetaData.getFunctionColumns() have to be used separately to retrieve the stored procedures information. |

@리뷰 국문과 내용은 일치하지만 7.3 Release Note의 내용과 함수 설명이 조금 달라서 내용 확인 한번만 해주세요.
Copy link
Collaborator Author

@Soyoon-Choi Soyoon-Choi Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 요청1: getprocedures_return_functions 속성에 관한 7.3 릴리즈 노트와 현재 국문 설명이 다른데...같은 뜻인지 아닌지 판단하기가 어려워 리뷰 요청 드립니다.
지난 히스토리를 찾아보니 #217 에서 수정되었고 최초 설명은 #84 에서 추가되었습니다.

"두 메소드의 반환 결과에 저장 함수의 포함 여부를 결정한다."라는 문장의 의미가 애매합니다. 저장 프로시저 관련 메소드 반환값을 설정하기 위한 속성인데,

  1. true로 할 경우 해당 메소드들의 결과에 저장 함수의 "리턴값"도 포함하지만 false일 경우 저장 함수의 "리턴값"을 포함하지 않는다
  2. true로 할 경우 해당 메소드들의 결과에 저장 함수의 "정보"가 포함되지만 false일 경우 저장 함수의 "정보"가 포함되지 않는다

둘 중 어떤 의미인지 헷갈릴 수도 있을 것 같아요. 어떤 내용인지 명확하게 해주시면 수정안 작성해보겠습니다.


국문 매뉴얼 현재 내용은 "DatabaseMetaData.getProcedures(), DatabaseMetaData.getProcedureColumns() 메소드 반환 결과에 저장 함수의 포함 여부를 설정한다.true는 저장 함수를 포함한다. false는 저장 함수를 포함하지 않는다. 저장 함수 정보를 얻으려면 DatabaseMetaData.getFunctions()와 DatabaseMetaData.getFunctionColumns()를 사용해야 한다."

릴리즈 노트에 해당 속성 설명은 "DatabaseMetaData.getProcedures(), getProcedureColumns()의 결과에 function 결과를 포함할지 설정한다. JDBC API Specification 4.2 표준은 function 정보를 제외하지만 Altibase JDBC 4.2는 클라이언트 하위 호환성을 위해 하위 버전과 같게 유지한다. 표준에 따라 function정보를 제외하려면 속성값을 false로 설정한다."

인데 두 설명이 같은 내용인가요?

##### getcolumns_return_jdbctype

| Default Value | false |
Expand Down Expand Up @@ -3539,12 +3547,12 @@ The following table lists the types of SQLSTATE which can occur in the Altibase

| Interface name | Specification Version | **Supported** | Details | Exceptions |
| :------------------------------------------------------ | --------------------- | ------------- | ------------------------------------------------------------ | ------------------------------------------------------------ |
| createBlob() | 4.0 | X | Does not support creating LOB object in Connection phase | SQLFeatureNotSupported error occurred |
| createClob() | 4.0 | X | Does not support creating LOB object in Connection phase | SQLFeatureNotSupported error occurred |
| createBlob() | 4.0 | O | Does not support long data type | |
| createClob() | 4.0 | O | Does not support long data type | |
| createNClob() | 4.0 | X | Does not support multinational language for CLOB object | SQLFeatureNotSupported error occurred |
| createSQLXML() | 4.0 | X | Does not support SQLXML type | SQLFeatureNotSupported error occurred |
| isValid(int timeout) | 4.0 | O | | |
| setClientInfo(String name, String value) | 4.0 | O | Altibase JDBC supports ApplicationName only among client attributes | |
| setClientInfo(String name, String value) | 4.0 | O | Supports ApplicationName only among client attributes | |
| setClientInfo(Properties properties) | 4.0 | O | Supports ApplicationName only | |
| getClientInfo(String name) | 4.0 | O | Supports ApplicationName only | |
| getClientInfo() | 4.0 | O | Supports ApplicationName only | |
Expand All @@ -3554,18 +3562,18 @@ The following table lists the types of SQLSTATE which can occur in the Altibase
| getSchema() | 4.1 | X | Does not support schema | Returns null instead of occurring an error |
| abort(Executor executor) | 4.1 | O | | |
| setNetworkTimeout(Executor executor, int milliseconds) | 4.1 | O | Executor can return NULL since SO_TIMEOUT socket option of TCP/IP connection is used internally | |
| getNetworkTimeout() | 4.1 | O | Synchronised with response_timeout property of JDBC and returns the property value of it | |
| getNetworkTimeout() | 4.1 | O | Synchronized with response_timeout property of JDBC and returns the property value of it | |

### java.sql.Wrapper

| Interface name | Specification Version | Supported | Details | Exceptions |
| ----------------------------- | --------------------- | --------- | ------- | ---------- |
| unwrap(Class iface) | 4.0 | O | | |
| unwrap(Class\<T> iface) | 4.0 | O | | |
Copy link
Collaborator Author

@Soyoon-Choi Soyoon-Choi Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 요청2: 기존 국문에서 unwrap(Class<T> iface)라고 되어 있었는데 마크다운 문법 때문에 <T> 부분이 코드처리 되어 보이지 않았습니다. 영문엔 아예 없었고요...따라서 <T>가 보일 수 있도록 수정했는데 혹시 틀렸다면 얘기해주세요~

| isWrapperFor(Class<?> iface) | 4.0 | O | | |

List of classes implementing java.sql.Wrapper interface in Altibase JDBC driver

- Altibase42Connection
- Altibase42Connection @리뷰 국문 AltiabseConnection
Copy link
Collaborator Author

@Soyoon-Choi Soyoon-Choi Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 요청3: java.sql.Wrapper 인터페이스를 구현하고 있는 Altiabse JDBC driver class입니다. 국문엔 AltibaseConnection이고 영문엔 Altibase42Connection인데 어느쪽이 맞는지 알려주시면 내용 일치시키겠습니다.

- AltibaseStatement
- AltibaseResultSet
- AltibaseResultSetMetaData
Expand Down Expand Up @@ -3639,10 +3647,10 @@ The following table lists the types of SQLSTATE which can occur in the Altibase
| getNString(int parameterIndex) | 4.0 | O | | |
| getNString(String parameterName) | 4.0 | O | | |
| setNString(String parameterName, String value) | 4.0 | O | | |
| getNCharacterStream(int parameterIndex) | 4.0 | X | Does not support NClob type | SQLFeatureNotSupported error occurred |
| getNCharacterStream(String parameterName) | 4.0 | X | Does not support NClob type | SQLFeatureNotSupported error occurred |
| setNCharacterStream(String parameterName, Reader reader) | 4.0 | X | Does not support NClob type | SQLFeatureNotSupported error occurred |
| setNCharacterStream(String parameterName, Reader value, long length | 4.0 | X | Does not support NClob type | SQLFeatureNotSupported error occurred |
| getNCharacterStream(int parameterIndex) | 4.0 | X | Does not support NCLOB type | SQLFeatureNotSupported error occurred |
| getNCharacterStream(String parameterName) | 4.0 | X | Does not support NCLOB type | SQLFeatureNotSupported error occurred |
| setNCharacterStream(String parameterName, Reader reader) | 4.0 | X | Does not support NCLOB type | SQLFeatureNotSupported error occurred |
| setNCharacterStream(String parameterName, Reader value, long length | 4.0 | X | Does not support NCLOB type | SQLFeatureNotSupported error occurred |
| getCharacterStream(int parameterIndex) | 4.0 | O | | |
| getCharacterStream(String parameterName) | 4.0 | O | | |
| setAsciiStream(String parameterName, InputStream x) | 4.0 | O | | |
Expand Down Expand Up @@ -3732,7 +3740,7 @@ The following table lists the types of SQLSTATE which can occur in the Altibase

| Interface name | Specification Version | Supported | Details | Exceptions |
| ------------------------------------------------------------ | --------------------- | --------- | ----------------------------- | -------------------------------------- |
| getRowIdLifetime() | 4.0 | X | Does not support RowId | SQLFeatureNotSupported error occurred |
| getRowIdLifetime() | 4.0 | X | Does not support RowId | SQLFeatureNotSupported error occurred |
| getSchemas(String catalog, String schemaPattern) | 4.0 | O | | |
| supportsStoredFunctionsUsingCallSyntax() | 4.0 | X | Returns false | |
| autoCommitFailureClosesAllResultSets() | 4.0 | X | Returns false | |
Expand Down