Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the auditor_apel_plugin to the repo #316

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

dirksammel
Copy link
Member

This PR adds the AUDITOR_APEL_plugin to this repo. GitHub workflows are omitted and will be added later.
Closes #311.

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #316 (3250925) into main (de42ae8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   56.02%   56.02%           
=======================================
  Files          41       41           
  Lines        3352     3352           
=======================================
  Hits         1878     1878           
  Misses       1474     1474           

@dirksammel dirksammel marked this pull request as ready for review July 10, 2023 09:48
Copy link
Contributor

@QuantumDancer QuantumDancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, see my comments below. They are mostly related to the integration of the APEL plugin to the Auditor repo. I didn't do any detailed review of the actual code, because this is not the main concern of this PR. But let me know if I should do so.

plugins/apel/LICENSE Outdated Show resolved Hide resolved
plugins/apel/README.md Outdated Show resolved Hide resolved
plugins/apel/auditor_apel_plugin.cfg Outdated Show resolved Hide resolved
plugins/apel/auditor_apel_plugin.cfg Outdated Show resolved Hide resolved
plugins/apel/codecov.yml Show resolved Hide resolved
plugins/apel/src/auditor_apel_plugin/core.py Show resolved Hide resolved
plugins/apel/src/auditor_apel_plugin/core.py Show resolved Hide resolved
@dirksammel dirksammel force-pushed the add_apel_plugin branch 2 times, most recently from ddb7707 to 2fb22dd Compare July 10, 2023 14:49
Copy link
Contributor

@QuantumDancer QuantumDancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dirksammel dirksammel merged commit 4de5681 into ALU-Schumacher:main Jul 11, 2023
@dirksammel dirksammel deleted the add_apel_plugin branch July 11, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AUDITOR_APEL_plugin: move code to AUDITOR repo
3 participants