Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a JOSS paper #260

Open
olevs opened this issue Dec 15, 2023 · 3 comments
Open

Create a JOSS paper #260

olevs opened this issue Dec 15, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@olevs
Copy link
Contributor

olevs commented Dec 15, 2023

Create and submit a code paper to Journal of Open Source Software (JOSS)

@olevs olevs added the enhancement New feature or request label Dec 15, 2023
@olevs olevs self-assigned this Dec 15, 2023
olevs added a commit to SINTEFMedtek/Slicer-Liver that referenced this issue Dec 15, 2023
olevs added a commit to SINTEFMedtek/Slicer-Liver that referenced this issue Dec 15, 2023
olevs added a commit to SINTEFMedtek/Slicer-Liver that referenced this issue Dec 20, 2023
olevs added a commit to SINTEFMedtek/Slicer-Liver that referenced this issue Jan 10, 2024
olevs added a commit to SINTEFMedtek/Slicer-Liver that referenced this issue Jan 12, 2024
olevs added a commit to SINTEFMedtek/Slicer-Liver that referenced this issue Jan 12, 2024
olevs added a commit to SINTEFMedtek/Slicer-Liver that referenced this issue Jan 12, 2024
olevs added a commit to SINTEFMedtek/Slicer-Liver that referenced this issue Jan 15, 2024
olevs added a commit to SINTEFMedtek/Slicer-Liver that referenced this issue Jan 15, 2024
olevs added a commit to SINTEFMedtek/Slicer-Liver that referenced this issue Jan 15, 2024
gatangen added a commit to SINTEFMedtek/Slicer-Liver that referenced this issue Jan 16, 2024
olevs added a commit to SINTEFMedtek/Slicer-Liver that referenced this issue Jan 18, 2024
olevs added a commit to SINTEFMedtek/Slicer-Liver that referenced this issue Jan 23, 2024
@olevs
Copy link
Contributor Author

olevs commented Jun 6, 2024

After the last merge the paper draft no longer builds. It seems like the code for converting *.svg files no longer functions correctly.
This is an issue with the JOSS script for github actions, and the github runners (github seems to update runners regularly).
It seems like the error is with rsvg-convert, and I tried to change draft-pdf.yml to install this explicitly, but it still fails. I also tried to change ubuntu runner from ubuntu-latest (22.04) to ubuntu-20.04, but I still get the same error.

The solution is either to try to fix the JOSS script(s), wait for JOSS to fix them, or manually convert the .svg images to another format (like .png).
@RafaelPalomar The simplest solution is probably to just convert the .svg images to another format.

@olevs
Copy link
Contributor Author

olevs commented Jun 6, 2024

I tested my previous suggestion in my separate test branch (with the first draft), and that worked fine.
On Ubuntu the conversion can be done with "rsvg-convert resectograms-overview.svg > resectograms-overview.png".
@RafaelPalomar Will you do it, or should I?

@RafaelPalomar
Copy link
Collaborator

@olevs I can do it. I'm checking the develop branch already

RuoyanMeng added a commit that referenced this issue Oct 18, 2024
* DOC: Added JOSS example paper and bib file templates. #260

* DOC: Added JOSS example text in paper.md. #260

* DOC: Add paper content

* DOC: Move pape to own folder

This moves the paper files to its own folder and modifies the github
workflow files to adjust for this

* DOC: Update paper conten

Co-authored-by: Ole Vegard Solberg <olevegard.solberg@sintef.no>
Co-authored-by: Geir Arne Tangen <Geir.A.Tangen@sintef.no>
Co-authored-by: Gabriella d'Albenzio <dalbenzio.gabriella@gmail.com>
Co-authored-by: Ruoyan Meng <ruoyanmeng@gmail.com>

* COMP: Fix paper pdf generation workflow

* DOC: Add atypical vs. anatomical figure to paper

* DOC: Fix typos in paper

* DOC: Fix figures

* DOC: Minor changes and typo fixes

* Add GdA ORCID

* Add Couinaud segments figure

* Add bib reference

* Paper revision GdA

* Fix typo in the text

* Remove { width=100% } under resectogram figure

* Revert "Remove { width=100% } under resectogram figure"

This reverts commit 3985a4e.

* DOC: Fixed ref to fig 4

* DOC: Minor additions to text.

* DOC: Minor text changes

* DOC: update pdf generator

* DOC: Changed Liver Volumetry description

* DOC: Update reference

* DOC: revise reference

---------

Co-authored-by: Ole Vegard Solberg <olevegard.solberg@sintef.no>
Co-authored-by: Geir Arne Tangen <Geir.A.Tangen@sintef.no>
Co-authored-by: Rafael Palomar <rafael.palomar@ous-research.no>
Co-authored-by: Gabriella d'Albenzio <dalbenzio.gabriella@gmail.com>
Co-authored-by: Ole Vegard Solberg <olevs@users.noreply.github.com>
Co-authored-by: Gabriella d' Albenzio <75131750+dalbenzioG@users.noreply.github.com>
Co-authored-by: Rafael Palomar <rafael@emacs-portable.fedora>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants