GHA: -Werror only for amici repo #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a couple of -Werror options enabled when running on GHA. However, we should also check for the repo name. If amici is used in tests of any downstream projects, we don't want errors. Also use CMake's `-Wno-dev` for non-amici-ci installations.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2481 +/- ##
========================================
Coverage 77.62% 77.62%
========================================
Files 324 324
Lines 20933 20933
Branches 1464 1464
========================================
Hits 16250 16250
Misses 4680 4680
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. |
FFroehlich
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a couple of -Werror options enabled when running on GHA. However, we should also check for the repo name.
If amici is used in tests of any downstream projects, we don't want errors.
Also use CMake's
-Wno-devfor non-amici-ci installations.Fixes #2477