Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake export config #2540

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Update CMake export config #2540

merged 4 commits into from
Oct 16, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 11, 2024

  • We don't need to find SuiteSparse - sundials takes care of that
  • Fixes some issues when consuming the amici-exported CMake config
  • Set CMAKE_PREFIX_PATH when configuring models
  • Install system-wide libsuitesparse-dev to make sure it doesn't interfere with our vendored version

We don't need to find SuiteSparse - sundials takes care of that
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.78%. Comparing base (4973321) to head (91f0a8e).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2540      +/-   ##
===========================================
+ Coverage    77.75%   77.78%   +0.02%     
===========================================
  Files          325      325              
  Lines        21058    21058              
  Branches      1473     1473              
===========================================
+ Hits         16373    16379       +6     
+ Misses        4658     4652       -6     
  Partials        27       27              
Flag Coverage Δ
cpp 73.49% <ø> (+0.02%) ⬆️
cpp_python 34.05% <ø> (ø)
petab 37.05% <ø> (ø)
python 72.33% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@dweindl dweindl marked this pull request as ready for review October 11, 2024 14:00
@dweindl dweindl requested a review from a team as a code owner October 11, 2024 14:00
@dweindl dweindl marked this pull request as draft October 11, 2024 20:38
@dweindl dweindl self-assigned this Oct 12, 2024
@dweindl dweindl marked this pull request as ready for review October 13, 2024 19:59
@dweindl dweindl marked this pull request as draft October 13, 2024 19:59
@dweindl dweindl marked this pull request as ready for review October 16, 2024 06:26
@dweindl dweindl merged commit ee2e0d2 into AMICI-dev:develop Oct 16, 2024
17 of 20 checks passed
@dweindl dweindl deleted the cmake_config branch October 16, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants