Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for unsupported observable IDs in sigma expressions #2563

Merged
merged 6 commits into from
Nov 6, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 23, 2024

Closes #2561.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.76%. Comparing base (2b05a19) to head (4e85838).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2563      +/-   ##
===========================================
+ Coverage    77.70%   77.76%   +0.06%     
===========================================
  Files          325      325              
  Lines        21857    21861       +4     
  Branches      1473     1473              
===========================================
+ Hits         16983    17000      +17     
+ Misses        4847     4834      -13     
  Partials        27       27              
Flag Coverage Δ
cpp 73.64% <100.00%> (+0.06%) ⬆️
cpp_python 34.21% <100.00%> (+0.01%) ⬆️
petab 37.09% <100.00%> (+0.01%) ⬆️
python 72.41% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/sbml_import.py 79.56% <100.00%> (+0.08%) ⬆️

... and 4 files with indirect coverage changes

@dweindl dweindl marked this pull request as ready for review October 23, 2024 18:59
@dweindl dweindl requested a review from a team as a code owner October 23, 2024 18:59
@dweindl dweindl self-assigned this Oct 23, 2024
@dweindl dweindl merged commit 0009c4a into AMICI-dev:develop Nov 6, 2024
26 checks passed
@dweindl dweindl deleted the fix_2561 branch November 6, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants