Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster fill_in_parameters_for_condition #2586

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 19, 2024

Avoid unnecessary repeated dict creation.
This matters for problems with large numbers of parameters.

Avoid unnecessary repeated dict creation.
This matters for problems with large numbers of parameters.
@dweindl dweindl requested a review from Doresic November 19, 2024 09:54
@dweindl dweindl requested a review from a team as a code owner November 19, 2024 09:54
@dweindl dweindl enabled auto-merge November 19, 2024 09:57
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.83%. Comparing base (a8da9cb) to head (f25a77b).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2586   +/-   ##
========================================
  Coverage    77.83%   77.83%           
========================================
  Files          325      325           
  Lines        21852    21853    +1     
  Branches      1456     1456           
========================================
+ Hits         17008    17009    +1     
  Misses        4833     4833           
  Partials        11       11           
Flag Coverage Δ
cpp 73.74% <0.00%> (-0.01%) ⬇️
cpp_python 34.21% <100.00%> (+<0.01%) ⬆️
petab 37.16% <100.00%> (+<0.01%) ⬆️
python 72.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/petab/conditions.py 97.45% <100.00%> (+0.02%) ⬆️
---- 🚨 Try these New Features:

@dweindl dweindl disabled auto-merge November 19, 2024 11:58
@dweindl dweindl merged commit 022de60 into AMICI-dev:develop Nov 19, 2024
18 of 20 checks passed
@dweindl dweindl deleted the faster_fillin branch November 19, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants