Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix amici.petab.import_helpers._can_import_model #2603

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 26, 2024

  • Use import_model_module
  • Use only the provided path, add set_path context manager
  • ModuleNotFoundError instead of FileNotFoundError

@dweindl dweindl self-assigned this Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.61%. Comparing base (4fcb14d) to head (d5ca083).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2603   +/-   ##
========================================
  Coverage    77.60%   77.61%           
========================================
  Files          329      329           
  Lines        21693    21701    +8     
  Branches      1477     1477           
========================================
+ Hits         16835    16843    +8     
  Misses        4847     4847           
  Partials        11       11           
Flag Coverage Δ
cpp 73.48% <100.00%> (+<0.01%) ⬆️
cpp_python 34.14% <100.00%> (+0.02%) ⬆️
petab 36.96% <100.00%> (+<0.01%) ⬆️
python 72.21% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/__init__.py 95.45% <100.00%> (+1.01%) ⬆️
python/sdist/amici/petab/import_helpers.py 85.93% <ø> (ø)

@dweindl dweindl marked this pull request as ready for review November 26, 2024 16:33
@dweindl dweindl requested a review from a team as a code owner November 26, 2024 16:33
@dweindl dweindl merged commit 4ed131b into AMICI-dev:develop Nov 27, 2024
18 of 20 checks passed
@dweindl dweindl deleted the fix_module_import branch November 27, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants