Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No module compilation for jax import #2609

Merged
merged 9 commits into from
Dec 2, 2024
Merged

No module compilation for jax import #2609

merged 9 commits into from
Dec 2, 2024

Conversation

FFroehlich
Copy link
Member

Disable module compilation for petab/jax import by default. Requires #2608.

@FFroehlich FFroehlich requested a review from a team as a code owner November 28, 2024 21:07
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.78%. Comparing base (1505d90) to head (8d32855).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2609   +/-   ##
========================================
  Coverage    77.78%   77.78%           
========================================
  Files          329      329           
  Lines        21724    21724           
  Branches      1477     1477           
========================================
  Hits         16899    16899           
  Misses        4814     4814           
  Partials        11       11           
Flag Coverage Δ
cpp 74.12% <ø> (-0.03%) ⬇️
cpp_python 34.13% <ø> (ø)
petab 36.96% <ø> (ø)
python 72.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/petab/petab_import.py 66.66% <ø> (ø)

@FFroehlich FFroehlich merged commit 851d389 into develop Dec 2, 2024
28 of 31 checks passed
@FFroehlich FFroehlich deleted the no_compile_jax branch December 2, 2024 13:32
Copy link

sonarqubecloud bot commented Dec 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants