Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if we are building with HIP, don't force inlining #1490

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Feb 21, 2024

this works around some issues with large kernels and ROCm

this works around some issues with large kernels and ROCm
Copy link
Collaborator

@yut23 yut23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove these flags from the HIP workflow now

@zingale zingale merged commit 3df6ba0 into AMReX-Astro:development Feb 22, 2024
27 checks passed
@zingale zingale deleted the fix-hip branch February 22, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants