Skip to content

Commit

Permalink
Fix a bug in EB tensor solver's cross term (#3465)
Browse files Browse the repository at this point in the history
Found by clang-tidy misc-redundant-expression.
  • Loading branch information
WeiqunZhang authored Aug 3, 2023
1 parent 67b8a5b commit 3af462c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Src/LinearSolvers/MLMG/AMReX_MLEBTensor_3D_K.H
Original file line number Diff line number Diff line change
Expand Up @@ -823,8 +823,8 @@ void mlebtensor_cross_terms (Box const& box, Array4<Real> const& Ax,
if (apz(i,j,k+1) > Real(0.0) && apz(i,j,k+1) < Real(1.0)) {
int ii = i + (fcz(i,j,k+1,0) >= Real(0.0) ? 1 : -1);
int jj = j + (fcz(i,j,k+1,1) >= Real(0.0) ? 1 : -1);
Real fracx = (ccm(ii,j,k) || ccm(ii,j,k)) ? std::abs(fcz(i,j,k+1,0)) : Real(0.0);
Real fracy = (ccm(i,jj,k) || ccm(i,jj,k)) ? std::abs(fcz(i,j,k+1,1)) : Real(0.0);
Real fracx = (ccm(ii,j,k) || ccm(ii,j,k+1)) ? std::abs(fcz(i,j,k+1,0)) : Real(0.0);
Real fracy = (ccm(i,jj,k) || ccm(i,jj,k+1)) ? std::abs(fcz(i,j,k+1,1)) : Real(0.0);
fzp_0 = (Real(1.0)-fracx)*(Real(1.0)-fracy) * fzp_0
+ fracx*(Real(1.0)-fracy) * fz(ii,j ,k+1,0)
+ fracy*(Real(1.0)-fracx) * fz(i ,jj,k+1,0)
Expand Down

0 comments on commit 3af462c

Please sign in to comment.