Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
WeiqunZhang authored Jul 24, 2024
1 parent 1667c84 commit 3c15ab5
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions Src/Base/AMReX_ParmParse.H
Original file line number Diff line number Diff line change
Expand Up @@ -1067,14 +1067,14 @@ public:
//! Make Parser using given string `func` as function body and `vars` as
//! variable names. Constants known to ParmParse will be set. It's a
//! runtime error, if there are unknown symbols in `func`.
Parser makeParser (std::string const& func,
Vector<std::string> const& vars) const;
[[nodiscard]] Parser makeParser (std::string const& func,
Vector<std::string> const& vars) const;

//! Make IParser using given string `func` as function body and `vars`
//! as variable names. Constants known to ParmParse will be set. It's a
//! runtime error, if there are unknown symbols in `func`.
IParser makeIParser (std::string const& func,
Vector<std::string> const& vars) const;
[[nodiscard]] IParser makeIParser (std::string const& func,
Vector<std::string> const& vars) const;

/**
* \brief Construct an initial ParmParse object from the argc and argv
Expand Down

0 comments on commit 3c15ab5

Please sign in to comment.