ParmPaser::queryAdd #2573
Merged
ParmPaser::queryAdd #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
force-pushed
the
queryadd
branch
4 times, most recently
from
a512042
to
be72fee
Compare
Add a new member function, queryAdd, to ParmParse. If the name is found, the value in the ParmParse database will be stored in the reference argument. If not, the value in the argument will be added to the ParmParse database. The return value indicates if it existed previously. Many codes use ParmParse::dumpTable to store the ParmParse data in plot/checkpoint files. But for parameters that not present in inputs files or command line arguments, they would not appear in the dumped tables. The new queryAdd function can be used to address this issue. In amrex/Src, the calls to `query` are replaced by `queryAdd` so that it's easy to find their values.
atmyers
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new member function, queryAdd, to ParmParse. If the name is found,
the value in the ParmParse database will be stored in the reference
argument. If not, the value in the argument will be added to the ParmParse
database. The return value indicates if it existed previously.
Many codes use ParmParse::dumpTable to store the ParmParse data in
plot/checkpoint files. But for parameters that not present in inputs files
or command line arguments, they would not appear in the dumped tables. The
new queryAdd function can be used to address this issue.
In amrex/Src, the calls to
queryare replaced byqueryAddso that it'seasy to find their values.
Checklist
The proposed changes: