Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs to reflect newer options in MLMG #2620

Merged
merged 8 commits into from
Feb 25, 2022

Conversation

cgilet
Copy link
Contributor

@cgilet cgilet commented Feb 8, 2022

Summary

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

const Vector<FabFactory<FArrayBox> const*>& a_factory = {},
Real a_const_sigma = Real(0.0));

Here, seting a constant :cpp:`sigma` alters the internals of the solver making it more
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Here, seting a constant :cpp:`sigma` alters the internals of the solver making it more
Here, setting a constant :cpp:`sigma` alters the internals of the solver making it more

Copy link
Contributor

@etpalmer63 etpalmer63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for improving the Linear Solver Docs!

@cgilet cgilet closed this Feb 11, 2022
@cgilet cgilet deleted the update_docs_mlmg branch February 11, 2022 15:05
@cgilet cgilet restored the update_docs_mlmg branch February 16, 2022 19:01
@cgilet cgilet reopened this Feb 16, 2022
@cgilet cgilet merged commit 067830e into AMReX-Codes:development Feb 25, 2022
@cgilet cgilet deleted the update_docs_mlmg branch February 25, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants