-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Tensor Solver BC #2930
Merged
Merged
Fix Tensor Solver BC #2930
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a0aa045
Fix Tensor Solver BC
WeiqunZhang beacfaa
Update compFlux and compVelGrad
WeiqunZhang 65d4585
Update Src/LinearSolvers/MLMG/AMReX_MLTensorOp_grad.cpp
WeiqunZhang c94d6d6
Update 3D fill_corners for EB
WeiqunZhang b381b6c
Merge branch 'tensor_bc' of github.com:WeiqunZhang/amrex into tensor_bc
WeiqunZhang 83b8ca5
Update apply
WeiqunZhang 9c6942d
first pass of EB Tensor
WeiqunZhang 44fb96a
fix for intel
WeiqunZhang 892925f
Merge branch 'development' into tensor_bc
WeiqunZhang e2e9ce4
typo
WeiqunZhang 71ae1d8
more intel fixes
WeiqunZhang 5b95543
fix bugs
WeiqunZhang 638f5b3
style
WeiqunZhang f7d992a
Merge branch 'development' into tensor_bc
WeiqunZhang 3285a5f
Reduce duplication by switching to shared verisons in AMReX_ML(EB)Ten…
cgilet 92350db
Clean up whitespace
cgilet 28abc32
Add in needed k (=0) for 2D calls to new shared functions
cgilet 3467be8
Make use of new functions in mltensor_vel_grad* as well
cgilet 39ead69
Fix compilation
cgilet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could
fluxfab_tmp
be allocated in The_Async_Arena ? (slightly orthogonal comment)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use The_Async_Arena, we will have to move
FArrayBox fluxfab_tmp[AMREX_SPACEDIM
into the MFIter loop body, becauseresize
does not work in this situation. The reason that resize works with Elixir is because Elxiir takes the ownership of the memory. But currently Elixir does not work with The_Async_Arena. We could make it work in the future. I think right now we can just leave it like this. For OpenMP, we do wantFArrayBox fluxfab_tmp
to be outside the MFIter loop so that they can be reused.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, thanks for checking !