Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation for PETSc #3005

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Fix compilation for PETSc #3005

merged 1 commit into from
Nov 1, 2022

Commits on Oct 31, 2022

  1. Fix compilation for PETSc 

    We cannot include PETSc headers too early because it might redefine MPI
routines as macros
(https://github.com/petsc/petsc/blob/main/include/petsclog.h#L441).  They
break MPI calls like below,

    MPI_Allreduce(&tmp, &vi, 1,
                  ParallelDescriptor::Mpi_typemap<T>::type(),
                  ParallelDescriptor::Mpi_op<T,amrex::Greater<T>>(), comm);

because of the `,` in `<T,amrex::Greater<T>>`.
    @WeiqunZhang
    WeiqunZhang committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    a442739 View commit details
    Browse the repository at this point in the history