Use less device memory when checkpointing particles #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers/amrex into less_device_mem_particle_checkpoint
|
The stream sync at line 188 is not needed. |
Same stream, per review.
WeiqunZhang
reviewed
Aug 23, 2023
| typename PC::IntVector write_int_comp_d(write_int_comp.size()); | ||
| typename PC::IntVector write_real_comp_d(write_real_comp.size()); | ||
| Gpu::copyAsync(Gpu::hostToDevice, write_int_comp.begin(), write_int_comp.end(), | ||
| write_int_comp_d.begin()); | ||
| Gpu::copyAsync(Gpu::hostToDevice, write_real_comp.begin(), write_real_comp.end(), | ||
| write_real_comp_d.begin()); | ||
| Gpu::Device::streamSynchronize(); | ||
| write_real_comp_d.begin());\ |
atmyers
commented
Aug 23, 2023
WeiqunZhang
approved these changes
Aug 23, 2023
…ers/amrex into less_device_mem_particle_checkpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This chunks the operation per box rather than per rank so as to use less device memory.
The proposed changes: