Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDF5 bug fix for vol-async and compression #3451

Merged
merged 5 commits into from
Jul 26, 2023

Conversation

houjun
Copy link
Contributor

@houjun houjun commented Jul 26, 2023

Summary

  • Fix a couple of issues with vol-async and SZ compression, regular HDF5 I/O should not be affected.
  • Changed BL_USE_MPI to AMREX_USE_MPI.

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

H5Z_HOME = /gpfs/alpine/csc300/world-shared/gnu_build/H5Z-ZFP/install
ZFP_HOME = /gpfs/alpine/csc300/world-shared/gnu_build/zfp
H5Z_HOME = /lustre/orion/geo130/world-shared/gnu/H5Z-ZFP
ZFP_HOME = /lustre/orion/geo130/world-shared/gnu/zfp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it makes sense to leave the Summit one in, but commented out?

Also, are these available for everyone to use, or do you need access to geo130?

Copy link
Contributor Author

@houjun houjun Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added the Summit paths that are commented out.
Everyone should be able to access the "world-shared" locations on both Summit and Frontier.

@atmyers atmyers enabled auto-merge (squash) July 26, 2023 20:57
@atmyers atmyers merged commit 49dd703 into AMReX-Codes:development Jul 26, 2023
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants