Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress implicit return warnings with nvcc #3463

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Aug 1, 2023

A bug in nvcc results in spurious warnings about implicit return statements when if constexpr is involved: https://stackoverflow.com/questions/64523302/cuda-missing-return-statement-at-end-of-non-void-function-in-constexpr-if-fun

Suppress those for now.

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers atmyers enabled auto-merge (squash) August 1, 2023 21:07
@atmyers atmyers merged commit 2de66d7 into AMReX-Codes:development Aug 1, 2023
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants