Fix: Backtraces will NULL Addresses #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handing of invalid stack addresses in backtraces was incomplete,
failing to run for stack addresses down a nullptr address with the
error:
```
sh: -c: line 0: syntax error near unexpected token `('
sh: -c: line 0: `/usr/bin/addr2line -Cpfie /gpfs/alpine/aph114/proj-shared/huebl/2023-08-21_ms-debugging-rz/002_btd_patch_pr4208/./warpx.rz (nil)'
```
WeiqunZhang
approved these changes
Aug 21, 2023
|
@WeiqunZhang oops, I was not yet done testing this (see little check in PR description) :) I think it might not write a Backtrace now at all 😅 |
|
Working on a patch... #3505 |
WeiqunZhang
pushed a commit
that referenced
this pull request
Aug 22, 2023
Follow-up to #3502. - [x] now tested :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The handing of invalid stack addresses in backtraces was incomplete, failing to run for stack addresses down a nullptr address with the error:
Additional background
Checklist
The proposed changes: