Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fortran inteface for FillCoarsePatch for face variables #3542

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Add Fortran inteface for FillCoarsePatch for face variables #3542

merged 1 commit into from
Sep 16, 2023

Conversation

WeiqunZhang
Copy link
Member

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@akashdhruv
Copy link
Contributor

I am testing this on Flash-X side. It looks good so far.

@WeiqunZhang
Copy link
Member Author

I have found an existing bug. I will submit a PR to fix that first before making this PR ready.

@WeiqunZhang WeiqunZhang marked this pull request as ready for review September 15, 2023 17:44
@WeiqunZhang WeiqunZhang linked an issue Sep 15, 2023 that may be closed by this pull request
Updating Fortran interface for amrex_fillcoarsepatch #3539
Closed
@asalmgren asalmgren merged commit e06025b into AMReX-Codes:development Sep 16, 2023
66 checks passed
@WeiqunZhang WeiqunZhang deleted the fifcp branch October 13, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalmgren asalmgren asalmgren approved these changes

@kngott kngott Awaiting requested review from kngott

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating Fortran interface for amrex_fillcoarsepatch
3 participants
@WeiqunZhang @akashdhruv @asalmgren