EB Data outside domain #3549
Merged
EB Data outside domain #3549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not guarantee there is valid EB information outside the domain, unless the user specifies a large enough number of ghost cells when building EB. However, this makes things difficult for application codes with AMR, because the number of ghost cells needed depends on the number of AMR levels. In this commit, we try to fill some basic EB information (EBCellFlag, volume fraction and area fraction) for all cells outside the domain.
asalmgren
approved these changes
Sep 17, 2023
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Sep 17, 2023
Area fractions are stored in MultiCutFabs that we must check if a fab is OK in MFIter for loop.
WeiqunZhang
added a commit
that referenced
this pull request
Sep 17, 2023
WeiqunZhang
added a commit
to WeiqunZhang/amrex
that referenced
this pull request
Sep 17, 2023
This is a follow-up on AMReX-Codes#3549. After extending EB data outside the domain, we need to update the EB Fab type.
Merged
WeiqunZhang
added a commit
that referenced
this pull request
Sep 17, 2023
This is a follow-up on #3549. After extending EB data outside the domain, we need to update the EB Fab type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not guarantee there is valid EB information outside the domain, unless the user specifies a large enough number of ghost cells when building EB. However, this makes things difficult for application codes with AMR, because the number of ghost cells needed depends on the number of AMR levels. In this commit, we try to fill some basic EB information (EBCellFlag, volume fraction and area fraction) for all cells outside the domain.