Rename scalar constant variables to ascalar and bscalar in linear solvers to avoid confusion
#3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to linear-solvers-rename-alpha-beta-scalars
…to linear-solvers-rename-alpha-beta-scalars
eebasso
changed the title
ascalar and bscalar instead of alpha and beta to avoid confusionascalar and bscalar in linear solvers to avoid confusion
…to linear-solvers-rename-alpha-beta-scalars
|
Let's not worry about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR renames the scalar constant variables towards the convention neutral names
ascalarandbscalaras opposed to eitherAandBoralphaandbeta.Additional background
Precedence for using the names
ascalarandbscalarcan be found in MLABecLaplacian.H, MLALaplacian.H, MLEBABecLap.H and various MyTest.H files. This naming scheme compliments that of the coefficients, often of the formacoeffs,a_coeffs, etc., as well as the functions namedsetAScalar(),setACoeffs, etc. For example, look at the usage ofacfandbcfin MLNodeABecLap_3D_K.H.Hopefully this change can be considered independently of whether the
A \alphaor\alpha Aconvention is preferred in the future. This is related to PR #3640.