Add PODVector::assign(value)
#3866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
commented
Apr 1, 2024
Src/Base/AMReX_PODVector.H
Outdated
| * | ||
| * @param a_value the value to assign | ||
| */ | ||
| void assign (const & T a_value) |
There was a problem hiding this comment.
We can also avoid an overload and call this setVal(value) in symmetry with MultiFab, what do you think?
Suggested change
| void assign (const & T a_value) | |
| void setVal (const T& a_value) |
There was a problem hiding this comment.
In MultiFabs, we further overload the assignment operator for amrex::Real and/or int, for convenience.
There was a problem hiding this comment.
I think assign is fine. It will still be asymmetric unless we add assign to MultiFab, which most versions would not make sense.
``` vector.assign(vector.size(), 42); ``` is a bit verbose for a standard operation, even if it mirrors https://en.cppreference.com/w/cpp/container/vector/assign Add another overload similar to `setVal(ue)` used in other AMReX containers.
WeiqunZhang
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
is a bit verbose for a standard operation, even if it mirrors https://en.cppreference.com/w/cpp/container/vector/assign
Add another overload similar to
setVal(ue)used in other AMReX containers.Additional background
AMReX-Codes/pyamrex#222 (comment)
Checklist
The proposed changes: