AMREX_ENUM and ParmParse support for enum class #4069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
force-pushed
the
amrex_enum
branch
from
b8a66d1
to
e1bfc5e
Compare
This adds AMREX_ENUM that can be used to define enum class with reflection. The new feature allows us to support enum class in ParmParse.
WeiqunZhang
force-pushed
the
amrex_enum
branch
from
e1bfc5e
to
082ad2d
Compare
atmyers
approved these changes
Aug 14, 2024
5 tasks
WeiqunZhang
pushed a commit
that referenced
this pull request
Sep 4, 2024
## Summary - The ParmParse functions for AMReX Enums added in #4069 did not carry the optional arguments found in other ParmParse functions. Those are added so that, for example, querying an enum has the same interface as querying other types. - These functions shouldn't modify the ParmParse object, so they are made `const` - The `prefixedName` function is made a public member instead of a protected member. ## Additional background The use case for these changes is erf-model/ERF#1772
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds AMREX_ENUM that can be used to define enum class with reflection. The new feature allows us to support enum class in ParmParse.