Support for multiple periods in FillBoundary and ParallelCopy #4106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a feature requested by a user who wants to run simulations with the number of ghost cells less than the domain length in periodic directions.
WeiqunZhang
force-pushed
the
multi-period
branch
from
8bfdf96
to
f09a8e2
Compare
asalmgren
approved these changes
Aug 22, 2024
|
My only comment is about the PR description: "This is a feature requested by a user who wants to run simulations with the number of ghost cells less than the domain length in periodic directions." That should read "This is a feature requested by a user who wants to run simulations with the number of ghost cells MORE than the domain length in periodic directions." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature requested by a user who wants to run simulations with the number of ghost cells more than the domain length in periodic directions.