use perl instead of sed in style checks for portability to MacOS #4127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sed -i
does not function the same for GNU and BSD sed and a simple portable command between the two is apparently not possible. Therefore, the style check scripts do not work by default when running on Macs, unless the user installsgsed
and aliasessed
to run that instead. For portability,perl
can be used instead ofsed
.Additional background
Proposed solution taken from here: https://stackoverflow.com/questions/4247068/sed-command-with-i-option-failing-on-mac-but-works-on-linux
Checklist
The proposed changes: