ParticleTileData Interface Changes #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
commented
Apr 8, 2023
ax3l
commented
Apr 8, 2023
5 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
134
to
+136
| // work-around for https://github.com/pybind/pybind11/pull/4581 | ||
| //make_ArrayOfStructs<NReal, NInt, std::allocator> (m, "std"); | ||
| //make_ArrayOfStructs<NReal, NInt, amrex::ArenaAllocator> (m, "arena"); | ||
| //make_ArrayOfStructs<ParticleType, std::allocator> (m, "std"); | ||
| //make_ArrayOfStructs<ParticleType, amrex::ArenaAllocator> (m, "arena"); |
Check notice
Code scanning / CodeQL
Commented-out code
ax3l
force-pushed
the
topic-new-ptd-interfaces
branch
2 times, most recently
from
2496779
to
1258cd9
Compare
ax3l
force-pushed
the
topic-new-ptd-interfaces
branch
from
6bca6cf
to
2e558aa
Compare
ax3l
force-pushed
the
topic-new-ptd-interfaces
branch
from
2e558aa
to
6dee0ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the legacy AoS-position-id particle layout in AMReX.
It just anticipates the changes in C++ APIs for
ArrayOfStructand(Const)ParticleTileDatafrom AMReX-Codes/amrex#2878