wrapper for concatenate function in amrex #145

RevathiJambunathan · 2023-07-13T00:03:26Z

In this PR, we add a wrapper to the concatenate function in amrex.

Thanks to the team effort by @EZoni @oshapoval @kngott and Scot Halverson.

EZoni · 2023-07-17T18:05:46Z

@RevathiJambunathan
Discussed offline with @ax3l, besides using the wrapper when converting the AMReX tutorials to pyamrex, it would be useful to add a small test of this function within one of the existing tests in the pyamrex repository.

src/pyAMReX.cpp

src/Base/Utility.cpp

src/pyAMReX.cpp

for more information, see https://pre-commit.ci

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

tests/test_utility.py

src/pyAMReX.cpp

tests/test_utility.py

ax3l

This looks great, thank you! 🚀 ✨

src/Base/Utility.cpp

wrapper for concatenate function in amrex

393c84e

ax3l self-requested a review July 17, 2023 18:48

ax3l self-assigned this Jul 17, 2023

ax3l added the enhancement New feature or request label Jul 17, 2023

ax3l reviewed Jul 17, 2023

View reviewed changes

src/pyAMReX.cpp Outdated Show resolved Hide resolved

ax3l reviewed Jul 17, 2023

View reviewed changes

src/pyAMReX.cpp Outdated Show resolved Hide resolved

ax3l reviewed Jul 17, 2023

View reviewed changes

src/Base/Utility.cpp Outdated Show resolved Hide resolved

ax3l reviewed Jul 17, 2023

View reviewed changes

src/pyAMReX.cpp Outdated Show resolved Hide resolved

RevathiJambunathan and others added 5 commits July 18, 2023 14:56

add test for concatenate function

8cec23e

[pre-commit.ci] auto fixes from pre-commit.com hooks

6102784

for more information, see https://pre-commit.ci

alphabetical order

7528618

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

alphabetical order

b51e139

user-facing function with py::arg

30a2d0a

Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>

github-advanced-security bot found potential problems Jul 18, 2023

View reviewed changes

tests/test_utility.py Fixed Show fixed Hide fixed

tests/test_utility.py Fixed Show fixed Hide fixed