Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init: Fix Use-after-Free #29

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Mar 25, 2022

Fix a use-after-free in init and add the ANSII C NULL padding (same as ECP-WarpX/WarpX#2726).

When pushing back extra arguments, un-reserved vectors resize and thus change memory locations.

Found via address+undefined sanitizers.

Fix a use-after-free in init and add the ANSII C NULL padding.
@ax3l ax3l added the bug Something isn't working label Mar 25, 2022
@ax3l ax3l requested a review from sayerhs March 25, 2022 01:06
@ax3l ax3l mentioned this pull request Mar 25, 2022
@ax3l ax3l merged commit 44a4012 into AMReX-Codes:development Mar 25, 2022
@ax3l ax3l deleted the fix-init-use-after-free branch March 25, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant