-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Particles: CUDA Array Interface #86
Merged
ax3l
merged 5 commits into
AMReX-Codes:development
from
ax3l:cuda-array-interface-particles
Feb 8, 2023
Merged
Particles: CUDA Array Interface #86
ax3l
merged 5 commits into
AMReX-Codes:development
from
ax3l:cuda-array-interface-particles
Feb 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
force-pushed
the
cuda-array-interface-particles
branch
2 times, most recently
from
October 20, 2022 23:45
c98d13d
to
1375411
Compare
ax3l
force-pushed
the
cuda-array-interface-particles
branch
from
February 4, 2023 07:02
1375411
to
bc83999
Compare
ax3l
force-pushed
the
cuda-array-interface-particles
branch
3 times, most recently
from
February 4, 2023 09:43
5179f9a
to
9218519
Compare
Add the `__cuda_array_interface__` to particles.
ax3l
force-pushed
the
cuda-array-interface-particles
branch
from
February 7, 2023 23:19
ba690df
to
26bd981
Compare
ax3l
force-pushed
the
cuda-array-interface-particles
branch
from
February 8, 2023 01:17
26bd981
to
20fe304
Compare
ax3l
force-pushed
the
cuda-array-interface-particles
branch
from
February 8, 2023 01:45
20fe304
to
9a4d7d8
Compare
.def("setSuperParticle", &ParticleTileDataType::setSuperParticle) | ||
// setter & getter | ||
.def("__setitem__", [](ParticleTileDataType &pdt, int const v, | ||
SuperParticleType const value) { pdt.setSuperParticle(value, v); }) |
Check notice
Code scanning / CodeQL
Large object passed by value
This parameter of type [const SuperParticleType](1) is 72 bytes - consider passing a const pointer/reference instead.
This parameter of type [const SuperParticleType](1) is 88 bytes - consider passing a const pointer/reference instead.
This parameter of type [const SuperParticleType](1) is 336 bytes - consider passing a const pointer/reference instead.
>; | ||
using ParticleInitData = typename ParticleContainerType::ParticleInitData; | ||
using ParticleTileType = typename ParticleContainerType::ParticleTileType; | ||
//using AoS = typename ParticleContainerType::AoS; |
Check notice
Code scanning / CodeQL
Commented-out code
This comment appears to contain commented-out code.
ax3l
changed the title
[WIP] Particles: CUDA Array Interface
Particles: CUDA Array Interface
Feb 8, 2023
Remove one unnecessary & untested combination.
ax3l
force-pushed
the
cuda-array-interface-particles
branch
from
February 8, 2023 06:11
4d3f151
to
7acf487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
__cuda_array_interface__
to particles.Similar to #30, related to #9
Follow-up: