CI: Print error reports when tests fail #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
force-pushed
the
topic-printFailedBuildTest
branch
from
dd6691a
to
9c8805d
Compare
|
can we make this an option? I run on the commandline a lot and this will really clutter things up. |
|
Yes, absolutely no problem :) Do you like to propose/push an option for it? |
|
what about just adding a general |
|
Sounds good to me, that would be on for our CI / non-interactive mode then :) |
|
With regards to #106: We could also add printing of |
This was referenced Jan 14, 2022
|
Option added in #116 :) |
zingale
approved these changes
Jan 15, 2022
|
I think we need to merge |
Print compilation messages and script output messages when they fail. This is needed for CI to spot the underlying error. Port of ECP-WarpX@8abcbe3 by @RemiLehe Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
ax3l
force-pushed
the
topic-printFailedBuildTest
branch
from
4a148c4
to
b483c36
Compare
|
Thx, yes rebased now :) |
zingale
reviewed
Jan 15, 2022
zingale
reviewed
Jan 15, 2022
ax3l
force-pushed
the
topic-printFailedBuildTest
branch
from
b483c36
to
97b87e3
Compare
|
@zingale thx, updated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print compilation messages and script output messages when
they fail. This is needed for CI to spot the underlying error.
Port of ECP-WarpX@8abcbe3 by @RemiLehe
ping @EZoni