run isothermal Soret channel as a test #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baperry2
force-pushed
the
soret-isothermal-test
branch
from
1dc3b25 to
db25cf2
Compare
ThomasHowarth
requested changes
Dec 31, 2024
Docs/sphinx/manual/LMeXControls.rst
Outdated
| When using the Soret effect, boundary condition corrections are needed at isothermal boundaries, | ||
| which are not fully supported. Currently a correction for all terms except the wbar term | ||
| is applied at isothermal domain boundaries (this is likely sufficient), while no corrections are applied | ||
| at isothemral embedded boundaries (so use caution for isothermal EBs with Soret diffusion active). |
There was a problem hiding this comment.
Oof. Clearly I hadn't woken back up all the way from the holidays when I made the fixes. Fixed now.
ThomasHowarth
requested changes
Jan 3, 2025
Docs/sphinx/manual/LMeXControls.rst
Outdated
| When using the Soret effect, boundary condition corrections are needed at isothermal boundaries, | ||
| which are not fully supported. Currently a correction for all terms except the wbar term | ||
| is applied at isothermal domain boundaries (this is likely sufficient), while no corrections are applied | ||
| at isothemral embedded boundaries (so use caution for isothermal EBs with Soret diffusion active). |
ThomasHowarth
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add case from #391 to run in CI
TODO: