Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IS-04-01] Much smaller zeroconf monkey patch #812

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

garethsb
Copy link
Contributor

@garethsb garethsb commented May 24, 2023

We can avoid zeroconf-monkey and adopt latest jstasiak/zeroconf, with a single-line monkey patch to be able to advertise the overlong service type "_nmos-registration._tcp".

Marmoset

…keypatch to be able to advertise the overlong service type "_nmos-registration._tcp"
Copy link
Contributor

@lo-simon lo-simon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garethsb garethsb merged commit aa58b5e into master Jun 28, 2023
@garethsb garethsb deleted the zeroconf-marmoset branch June 28, 2023 14:07
jonathan-r-thorpe pushed a commit that referenced this pull request Jul 20, 2023
[IS-04-01] Much smaller zeroconf monkey patch

(cherry picked from commit aa58b5e)
jonathan-r-thorpe pushed a commit to jonathan-r-thorpe/nmos-testing that referenced this pull request Jul 20, 2023
[IS-04-01] Much smaller zeroconf monkey patch

(cherry picked from commit aa58b5e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants