Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when reindexing deleted files. #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mistermult
Copy link

This fixes #1 by setting in_trash=false (instead of None/null), when the the file is indexed.

@hfchendrikx
Copy link
Contributor

Thanks for taking the time to report and fix the issue.

I think that just putting in_trash to false doesn't really solve the core of the problem. When doing that bags that have been marked as trash will reappear when indexing. It would be better if they stay in the trash.

The real problem here is that the list_bags call does not return bags that are in the trash. The best fix IMO would be to either call list_bags twice for both trash and non-trashed bags and join those lists, or modify the list_bags endpoint to be able to return both trashed and non-trashed bags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Exception when reindexing trashed file.
3 participants