fix(heatmap): destroy canvas bbox calculator when done (opensearch-pr…

…oject#844)
AMoo-Miki · Oct 5, 2020 · 4c1fd55 · 4c1fd55
1 parent 5e221a4
commit 4c1fd55
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/packages/osd-charts/src/chart_types/heatmap/state/selectors/compute_chart_dimensions.ts b/packages/osd-charts/src/chart_types/heatmap/state/selectors/compute_chart_dimensions.ts
@@ -81,9 +81,8 @@ export const computeChartDimensionsSelector = createCachedSelector(
         };
       });
       const measuredYValues = textMeasure(config.yAxisLabel.fontSize, boxedYValues);
-      const maxTextWidth = d3Max(measuredYValues, ({ width }) => width) ?? 0;
 
-      let yColumnWidth: number = maxTextWidth;
+      let yColumnWidth: number = d3Max(measuredYValues, ({ width }) => width) ?? 0;
       if (typeof config.yAxisLabel.width === 'number') {
         yColumnWidth = config.yAxisLabel.width;
       } else if (typeof config.yAxisLabel.width === 'object' && yColumnWidth > config.yAxisLabel.width.max) {

diff --git a/packages/osd-charts/src/chart_types/heatmap/state/selectors/get_x_axis_right_overflow.ts b/packages/osd-charts/src/chart_types/heatmap/state/selectors/get_x_axis_right_overflow.ts
@@ -52,7 +52,7 @@ export const getXAxisRightOverflow = createCachedSelector(
       const textSize = bboxCompute.compute(text, padding, fontSize, fontFamily, 1);
       return Math.max(acc, textSize.width + padding);
     }, 0);
-
+    bboxCompute.destroy();
     return maxTextWidth / 2;
   },
 )(getChartIdSelector);