[CCI] feat: add missing createConnection type (opensearch-project#490)

* feat: add missing createConnection type Signed-off-by: Timur Bolotov <bolotovtmr@gmail.com>
AMoo-Miki · Jul 12, 2023 · e8d88fd · e8d88fd
1 parent c87780b
commit e8d88fd
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -76,6 +76,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Removed unnecessary `data` argument when invoking `OpenSearchClientError` ([#421](https://github.com/opensearch-project/opensearch-js/pull/421))
 - Fixed typos in `ConnectionPool` ([#427](https://github.com/opensearch-project/opensearch-js/pull/427))
 - Added the solution for the possible error during yarn installation on Windows OS ([#435](https://github.com/opensearch-project/opensearch-js/issues/435))
+- Added missing `createConnection` method type definition in `BaseConnectionPool` )([#490](https://github.com/opensearch-project/opensearch-js/pull/490))
 
 ### Dependencies
 

diff --git a/lib/pool/index.d.ts b/lib/pool/index.d.ts
@@ -115,6 +115,13 @@ declare class BaseConnectionPool {
    * @returns {object|null} connection
    */
   getConnection(opts?: getConnectionOptions): Connection | null;
+
+  /**
+   * Creates a new connection instance.
+   * @param {object|string} opts
+   * @returns {Connection}
+   */
+  createConnection(opts: ConnectionOptions | string): Connection;
   /**
    * Adds a new connection to the pool.
    *

diff --git a/test/types/connection-pool.test-d.ts b/test/types/connection-pool.test-d.ts
@@ -60,6 +60,7 @@ import { ConnectionOptions } from '../../lib/Connection';
       now: Date.now(),
     })
   );
+  expectType<Connection>(pool.createConnection({ url: new URL('url') }));
   expectType<Connection>(pool.addConnection({ url: new URL('url') }));
   expectType<BaseConnectionPool>(pool.removeConnection(new Connection()));
   expectType<void>(pool.empty());