-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMP: Add support for python 3.11, remove 3.6 from CI build wheels #426
Conversation
Testing if this will work with an update to cibuildwheel version Also update the python setup app to avoid Github deprecation warnings
@stnava updating |
In my testing py311 on Looks like the error stems from the removal of a deprecated function in py311:
linux_aarch64: https://cirrus-ci.com/task/4594148041293824?logs=run_cibuildwheel#L4831 + sh -c 'bash /project/tests/run_tests.sh'
/project/tests /tmp/tmp.fiarH5EVBZ/test_cwd
Running core tests
Traceback (most recent call last):
File "/project/tests/test_core_ants_image.py", line 19, in <module>
import ants
File "/tmp/tmp.fiarH5EVBZ/venv/lib/python3.11/site-packages/ants/__init__.py", line 7, in <module>
from .core import *
File "/tmp/tmp.fiarH5EVBZ/venv/lib/python3.11/site-packages/ants/core/__init__.py", line 2, in <module>
from .ants_image import *
File "/tmp/tmp.fiarH5EVBZ/venv/lib/python3.11/site-packages/ants/core/ants_image.py", line 598, in <module>
args = inspect.getargspec(getattr(utils,k)).args
^^^^^^^^^^^^^^^^^^
AttributeError: module 'inspect' has no attribute 'getargspec'. Did you mean: 'getargs'?
✕ 695.36s
Error: Command ['sh', '-c', 'bash /project/tests/run_tests.sh'] failed with code 1. macosx_arm64: https://cirrus-ci.com/task/6031614673682432?logs=run_cibuildwheel#L6089 + /bin/sh -c 'bash /private/var/folders/76/zy5ktkns50v6gt5g8r0sf6sc0000gn/T/cirrus-ci-build/tests/run_tests.sh'
/private/var/folders/76/zy5ktkns50v6gt5g8r0sf6sc0000gn/T/cirrus-ci-build/tests /private/var/folders/76/zy5ktkns50v6gt5g8r0sf6sc0000gn/T/cibw-run-_69wckud/cp311-macosx_arm64/test_cwd
Running core tests
Traceback (most recent call last):
File "/private/var/folders/76/zy5ktkns50v6gt5g8r0sf6sc0000gn/T/cirrus-ci-build/tests/test_core_ants_image.py", line 19, in <module>
import ants
File "/private/var/folders/76/zy5ktkns50v6gt5g8r0sf6sc0000gn/T/cibw-run-_69wckud/cp311-macosx_arm64/venv-test/lib/python3.11/site-packages/ants/__init__.py", line 7, in <module>
from .core import *
File "/private/var/folders/76/zy5ktkns50v6gt5g8r0sf6sc0000gn/T/cibw-run-_69wckud/cp311-macosx_arm64/venv-test/lib/python3.11/site-packages/ants/core/__init__.py", line 2, in <module>
from .ants_image import *
File "/private/var/folders/76/zy5ktkns50v6gt5g8r0sf6sc0000gn/T/cibw-run-_69wckud/cp311-macosx_arm64/venv-test/lib/python3.11/site-packages/ants/core/ants_image.py", line 598, in <module>
args = inspect.getargspec(getattr(utils,k)).args
^^^^^^^^^^^^^^^^^^
AttributeError: module 'inspect' has no attribute 'getargspec'. Did you mean: 'getargs'?
✕ 223.62s
Error: Command ['/bin/sh', '-c', 'bash /private/var/folders/76/zy5ktkns50v6gt5g8r0sf6sc0000gn/T/cirrus-ci-build/tests/run_tests.sh'] failed with code 1. None |
Thanks @ravnoor . I guess this means the build wheel action is not running the tests, because it completes successfully on cp11. I looked around for a solution to the Mac cp36 failure, but could not find an answer. |
As I understand it, #424 fixes the problems with cp11. Should I remove cp36 from the build matrix? Seems it no longer builds either here or on cirrus. |
I think it should be fine since python 3.6 has been end-of-life since 12/2021 |
Looks good now, thanks all |
Testing if this will work with an update to cibuildwheel version
Also update the python setup app to avoid Github deprecation warnings