-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMP: Add support for Python 3.12 #510
Conversation
@cookpa @stnava @ntustison I have left py37 in the GitHub CI workflow for now, but it probably should be removed since it's been EOL for 4 months now. Besides, |
Hi, sorry for the delay in getting to this. I'm happy to remove Python 3.7 |
- based on bookworm-slim image - uses latest `Miniconda3-py310_23.11.0-1`
- deprecated in py312
- no longer available by default
Done, and all checks passing |
Thanks for doing this @ravnoor - I'm re-running the failed windows build now. It randomly fails sometimes and I have not been able to figure out why |
apologies - but can you guys remind me what's needed for getting wheels on pypi ? I think last time I just downloaded them from GitHub then pushed them to pypi .... I am happy to add whoever to pypi "management" team if you have accounts there. |
Oh yes I should look into PyPI. I got a bunch of errors about that last time I ran a release action. I think it authenticated but couldn't find the wheels, possibly a simple fix. I think it just needs to point to the individual wheel subdirs
|
I have seen GHA jobs randomly fail for no apparent reason. This failure seems like one of those. Tests all passed OK, so I counted it as a pass. |
@stnava @cookpa I can take a more in-depth look at this. I was able to get TestPyPI to work to the point where everything but the upload worked since I don't have access to the project on test.pypi.org. If you can generate an API token or delegate access, I can test it end-to-end, and then push the same changes for PyPI. |
I invited @ravnoor as a manager on pypi |
Looks like I've the PyPI uploads figured out. I'll clean it up and make a new PR. In past conversations, I recall discussing the limit for uploading packages to PyPI. What is it exactly? This may limit how many builds across platforms (linux,macosx,win) and architectures (x86_64,arm64) and python versions (py38-py312) we could upload. To accommodate all, we would need 6700 MB [5 python versions x 1340] per version/release. Based on the most recent build, here's a break down of the build sizes:
Is there a consensus on what to include/exclude? @stnava @ntustison @cookpa From the CI perspective, a simple regex can enforce the upload inclusions/exclusion. |
these is the current information from pypi:
|
I think based on your numbers, we could request increases for pypi quotas for both total project size and upload limit. |
Yes, an increase would make sense to future-proof against hitting any quota limits |
All tests passing and building successfully:
linux_aarch64
andmacos_arm64
)linux_aarch64
andlinux_amd64
)Wheels (and detailed logs) can be found here: https://cirrus-ci.com/build/5424545834729472
I haven't tested the
amd64
wheels for Windows/Linux/MacOS due to concurrency limits on Cirrus CI, but GitHub Actions should fill in the gap.