Add ci-windows-artifacts #1923
Merged
Add ci-windows-artifacts #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrabaud
approved these changes
Jan 10, 2024
|
See https://docs.github.com/en/actions/managing-workflow-runs/downloading-workflow-artifacts for downloading |
wantehchang
reviewed
Jan 11, 2024
| - name: Build libyuv | ||
| if: steps.cache-ext.outputs.cache-hit != 'true' | ||
| working-directory: ./ext | ||
| run: ./libyuv.cmd |
There was a problem hiding this comment.
Thank you for adding this CI workflow.
We should use clang-cl to build libyuv. The assembly code in libyuv is written in the GCC inline assembly format. Visual C++ doesn't support GCC inline assembly.
In appveyor.yml this is done as follows:
- set "CC=clang-cl" && set "CXX=clang-cl"
- libyuv.cmd
- set "CC=" && set "CXX="
There was a problem hiding this comment.
I was wondering why these lines were there. Thanks for the explanation.
Done in #1930.
y-guyon
added a commit
to y-guyon/libavif
that referenced
this pull request
Jan 24, 2024
y-guyon
added a commit
to y-guyon/libavif
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.