Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from gcc 13 to gcc 12 in ubuntu-latest #2164

Merged
merged 1 commit into from
May 20, 2024

Conversation

wantehchang
Copy link
Collaborator

gcc-13 was removed from the ubuntu-22.04 os image. See actions/runner-images#8555 (comment)

gcc-13 was removed from the ubuntu-22.04 os image. See
actions/runner-images#8555 (comment)
@wantehchang wantehchang requested review from vigneshvg and jzern May 20, 2024 21:58
@wantehchang
Copy link
Collaborator Author

@vrabaud @y-guyon FYI.

There are two other options:
actions/runner-images#9866 (comment)

@wantehchang wantehchang merged commit c6eb2e4 into AOMediaCodec:main May 20, 2024
20 checks passed
@wantehchang wantehchang deleted the gcc-14-in-ubuntu-24-04 branch May 20, 2024 22:31
@jzern
Copy link
Collaborator

jzern commented May 20, 2024

lgtm.

@wantehchang
Copy link
Collaborator Author

Note that the ubuntu-latest alias is still pointing to ubuntu-22.04. It is ubuntu-22.04 itself that changed.

@vrabaud
Copy link
Collaborator

vrabaud commented May 21, 2024

Why even mention a specific version ? Doesn't the default gcc work anyway ?

@kmilos
Copy link
Contributor

kmilos commented May 21, 2024

Why even mention a specific version ?

More recent versions are generally more strict (upgrading warnings to errors), thus providing slightly better coverage hopefully. The default in 22.04 is 11 AFAIK...

Note that there is now the ubuntu-24.04 runner available in beta that provides 13 by default, and 14.

@vrabaud
Copy link
Collaborator

vrabaud commented May 21, 2024

@wantehchang
Copy link
Collaborator Author

Vincent:

The use of a specific version of gcc started in the very first version of these CI workflow files (.github/workflows/ci.yml):
0f8fcf8db

I guess the reason was what Miloš said, to use the newest version of gcc in the os image, rather than the default version.

The ubuntu-24.04 os image still has the "beta" status. That's why I didn't consider it yesterday. I probably would wait until ubuntu-24.04 goes out of beta, but we can certainly volunteer to be a beta tester.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants