Refactor gain map API #2444
Merged
Refactor gain map API #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remote avifGainMapMetadata and avifGainMapMetadataDouble which were not extensible. Expose avifDoubleTo(Un)SignedFraction instead.
y-guyon
approved these changes
Sep 26, 2024
maryla-uc
force-pushed
the
gainmapapi
branch
from
1448be6 to
641deb2
Compare
wantehchang
reviewed
Sep 26, 2024
| { | ||
| uint32_t positive_numerator; | ||
| if (!avifDoubleToUnsignedFractionImpl(fabs(v), INT32_MAX, &positive_numerator, denominator)) { | ||
| if (!avifDoubleToUnsignedFractionImpl(fabs(v), INT32_MAX, &positive_numerator, &fraction->d)) { |
There was a problem hiding this comment.
In avifDoubleToUnsignedFractionImpl(), the variable maxD is declared as uint64_t, but it is only used in a comparison with newD, which is a double. So maxD could be declared as double. If maxD should have an integer type, uint32_t is sufficient.
wantehchang
reviewed
Sep 27, 2024
|
@vigneshvg FYI. @maryla-uc Maryla: Could you or Vignesh port the changes to the public header avif.h to CrabbyAvif? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avifGainMapMetadata and avifGainMapMetadataDouble were not future proof. Instead of adding Create()/Destroy() functions, simply inline avifGainMapMetadata inside avifGainMap and remove avifGainMapMetadataDouble.
Add avifSignedFraction (int32/uint32) and avifUnsignedFraction (uint32/uint32), in addition to the existing avifFraction (int32/int32). It's unfortunate that avifFraction uses a int32 denominator, but I don't think this can be changed now. This is not strictly necessary but makes the API a bit neater.
Expose avifDoubleToSignedFraction and avifDoubleToUnsignedFraction in avif.h
This is not strictly necessary either, since users should rarely have to fill in the fraction values themselves, and even if they do, they can use a naive method like setting the denominator to a large fixed value. But they are convenient and avifjpeg.c does use them right now. However, I'm open to removing them from the API, or putting them behind AVIF_ENABLE_EXPERIMENTAL_GAIN_MAP (although this define should go away eventually).