Significantly simplify gain map API #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wantehchang
reviewed
Oct 20, 2024
wantehchang
reviewed
Oct 23, 2024
wantehchang
approved these changes
Oct 23, 2024
src/read.c
Outdated
|
|
||
| // If the item is a grid, copies the codec type property (av1C or av2C) from the first grid tile to the grid item. | ||
| // Also checks that all tiles have the same codec type and that it's valid. | ||
| static avifResult avifAdoptGridTileCodecTypeIfNeeded(avifDecoder * decoder, avifDecoderItem * item, const avifTileInfo * info) |
There was a problem hiding this comment.
Nit: Same here, this function probably should be named "avifDecoderAdoptGridTileCodecTypeIfNeeded".
y-guyon
approved these changes
Oct 24, 2024
Gain map metadata is now alwayas parsed (when gain map code is enabled at compile time). Ideally, gain map metadata should be stored towards the beginning of the file (since it's in the 'mdat' part).
It can be replaced with a check that image->gainMap is not NULL.
And rename to AVIF_IMAGE_CONTENT_...
copybara-service bot
pushed a commit
to webmproject/CrabbyAvif
that referenced
this pull request
Oct 24, 2024
Following changes in libavif AOMediaCodec/libavif#2481 PiperOrigin-RevId: 689374767
copybara-service bot
pushed a commit
to webmproject/CrabbyAvif
that referenced
this pull request
Oct 24, 2024
Following changes in libavif AOMediaCodec/libavif#2481 PiperOrigin-RevId: 689374767
copybara-service bot
pushed a commit
to webmproject/CrabbyAvif
that referenced
this pull request
Oct 25, 2024
Following changes in libavif AOMediaCodec/libavif#2481 PiperOrigin-RevId: 689374767
copybara-service bot
pushed a commit
to webmproject/CrabbyAvif
that referenced
this pull request
Oct 29, 2024
Following changes in libavif AOMediaCodec/libavif#2481 PiperOrigin-RevId: 689374767
copybara-service bot
pushed a commit
to webmproject/CrabbyAvif
that referenced
this pull request
Oct 29, 2024
Following changes in libavif AOMediaCodec/libavif#2481 PiperOrigin-RevId: 689374767
copybara-service bot
pushed a commit
to webmproject/CrabbyAvif
that referenced
this pull request
Oct 29, 2024
Following changes in libavif AOMediaCodec/libavif#2481 PiperOrigin-RevId: 689374767
copybara-service bot
pushed a commit
to webmproject/CrabbyAvif
that referenced
this pull request
Oct 29, 2024
Following changes in libavif AOMediaCodec/libavif#2481 PiperOrigin-RevId: 690987236
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enableParsingGainMapMetadata: gain map metadata is always parsed nowenableDecodingGainMapandignoreColorAndAlphawithimageContentToDecodebit fieldgainMapPresent, the same information is available by checkingdecoder->image->gainMap != NULL