Fuzztest clean-ups #2529
Open
Fuzztest clean-ups #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vrabaud
commented
Dec 23, 2024
vrabaud
commented
- merge AVIF_ENABLE_FUZZTEST and AVIF_LOCAL_FUZZTEST
- allow for fuzztest be built from CMake
- merge AVIF_ENABLE_FUZZTEST and AVIF_LOCAL_FUZZTEST - allow for fuzztest be built from CMake
wantehchang
reviewed
Dec 23, 2024
| @@ -142,9 +142,6 @@ option( | |||
| "Build tests that compare encoding outputs to golden files. Needs AVIF_BUILD_APPS=ON and AVIF_BUILD_TESTS=ON, and depends on MP4box which can be built with ext/mp4box.sh" | |||
| OFF | |||
| ) | |||
| option(AVIF_ENABLE_FUZZTEST "Build avif fuzztest targets. Requires Google FuzzTest. Has no effect unless AVIF_BUILD_TESTS is ON." | |||
| OFF | |||
| ) | |||
There was a problem hiding this comment.
I am wondering why you didn't use the AVIF_FUZZTEST=SYSTEM/LOCAL/OFF convention for FuzzTest.
There was a problem hiding this comment.
SYSTEM is most likely not available and even if it were, our dependency on fuzztest is so weak that it's better we handle it ourselves with LOCAL only: we know our dependency works with a particular sha1+patches. I did not try with more recent versions (as long as the CMake issues are not fixed, there is no point in trying anything newer).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.