-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter rooms by Tags #197
base: master
Are you sure you want to change the base?
Filter rooms by Tags #197
Conversation
@chandansgowda I have implemented the feature. Let me know if any other changes are required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job till here @ShivamMenda
I see that you are selecting two or three tags together and filtering. Make it as one tag. also improve the UI which comes below the app bar.
@chandansgowda selecting one tag which means, the user should be able to select only one tag at a time or there should be options of only one tag? Also regarding the UI where do you want me to keep the filter button? |
@ShivamMenda Please contact appwrite team and get an idea of an efficient database design for the same. |
@chandansgowda Sire will discuss with them. |
Any updates @ShivamMenda ? |
@chandansgowda dm'd a few people from the appwrite server. Did not get a reply. I'll put up a message in the flutter channel directly today. Will keep you posted. |
@ShivamMenda You can raise a ticket in their support channel. |
@chandansgowda will do that. |
Hey @ShivamMenda great work, cool new addition Please do make the requested changes and we will merge it asap |
Also @ShivamMenda is the appwrite collection and system structure already implemented for this feature ?? Please do give me an update on were are we on this |
@Aarush-Acharya I had proposed this issue long time back, and had implemented it to an extent, but I think we need to discuss on how we can change the room db structure a little so that this feature can be implemented in the existing codebase. |
Understood @ShivamMenda will look into it |
Hey @ShivamMenda, please do let me know what do you propose as an alteration of the current room db structure for it to work Also now as we have the entire backend hosted locally please do, change the structure for yourself local and have it done |
Description
This pull request introduces a feature to filter rooms by the tags given by the user.
Fixes #188
Type of change
How Has This Been Tested?
filter-rooms.mp4
Checklist:
Maintainer Checklist